hrw4u: Adds QP parameter indexing by name#12853
Open
zwoop wants to merge 2 commits intoapache:masterfrom
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request adds support for indexing query parameters by name in the hrw4u tool. The feature allows users to access specific URL query parameter values using the syntax <url_prefix>.query.<param_name>, where the parameter names are case-sensitive and matched without URL decoding.
Changes:
- Added query parameter indexing support for all URL contexts:
inbound.url.query,outbound.url.query,from.url.query, andto.url.query - Enhanced the parser to handle multi-colon tags for query parameters (e.g.,
%{CLIENT-URL:QUERY:version}) - Added documentation and examples explaining the new query parameter syntax and behavior
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| tools/hrw4u/src/tables.py | Added mapping entries for query parameter access on all four URL types (inbound, outbound, from, to) with proper validation and section constraints |
| tools/hrw4u/src/hrw_symbols.py | Enhanced multi-colon tag parsing logic to properly handle query parameter tags alongside existing certificate tags |
| tools/hrw4u/tests/data/conds/query-param.input.txt | Test input demonstrating query parameter usage across different contexts and sections |
| tools/hrw4u/tests/data/conds/query-param.output.txt | Expected output showing proper translation to header_rewrite format with QUERY tags |
| tools/hrw4u/tests/data/conds/query-param.ast.txt | AST representation of the parsed query parameter test cases |
| doc/admin-guide/configuration/hrw4u.en.rst | Documentation updates including condition mapping table entries and new example section with usage notes |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.